Move shared workflows into folder '.github/workflows/shared' #3004
Conversation
This helps to distinguish workflows shared with and called from other repositories and workflows only used in this repository.
|
This is a good idea! For me, it would also help to give more structure to the shared workflows, i.e., to better separate them by purpose. So would it make sense to take the chance and also give the shared workflows more structure (e.g., by placing them in further subfolders)? Would probably be a good point in time since we need to touch consumers anway. One proposal (without thinking much about it, so feel free to propose something else):
|
|
https://docs.github.com/en/actions/sharing-automations/reusing-workflows says:
See also If anything is unclear we have: that hopefully explains the what and how and can be structured of course.
Please keep in mind that they are used elsewhere (e.g. Tycho, m2e, jdt.ls...) so renaming them can have an undesirable impact on an unknown number of projects maybe. |
|
This one has many conflicts. Please rebase it. |
There was a problem hiding this comment.
If you are already moving the file, would it be a good idea to fix a typo in the same PR? Specifically, the message should probably be "Please always use rebase to update your branch" instead of "Please always use reabase to update your branch". Alternatively, this could be done in another PR before rebasing.
There was a problem hiding this comment.
@danthe1st please suggest a PR to fix the typo this is can be fixed beforehands already.
|
This PR seems to move all workflows mentioned in |
We have more and more GH workflows in this repository that are shared with other repos.
While this is good from a unification POV, it becomes more and more difficult to distinguish which workflow is a shared one and which workflow is just used in this repository.
Therefore this PR proposes to move all shared workflows into a sub-folder named
shared, in in order to helps to distinguish workflows shared with and called from other repositories and workflows only used in this repository.If we have consensus on this change I can create corresponding PRs to adapt all calling projects in the SDK.
This would also be a good opportunity to rename workflows if we think there current name does not fit.